Merged
Conversation
Jahnp
approved these changes
Apr 10, 2018
| flexWrap: 'nowrap', | ||
| alignItems: 'stretch', | ||
| padding: '0 0 0 8px', | ||
| // The 1px top and bottom padding ensure the input field does not overlap the border |
Member
There was a problem hiding this comment.
Just confirming--these get RTL-ified automatically, right?
Collaborator
Author
There was a problem hiding this comment.
I'm 90% sure js styling does handle this automagically. I'll confirm.
mikewheaton
approved these changes
Apr 10, 2018
Jahnp
approved these changes
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
We worked with a product team and design to come up with a more reasonable padding left for the default SearchBox. Underlined SearchBox needs to maintain its larger padding left for other product scenarios.
I also added a small top and bottom padding because the input field is sometimes overlaps the border when rendered.
Focus areas to test
(optional)