Skip to content

DetailsList: Fix focus high contrast color#8714

Merged
joschect merged 2 commits into
microsoft:masterfrom
joschect:fix-detailslist-highcontrast
Apr 12, 2019
Merged

DetailsList: Fix focus high contrast color#8714
joschect merged 2 commits into
microsoft:masterfrom
joschect:fix-detailslist-highcontrast

Conversation

@joschect
Copy link
Copy Markdown
Contributor

@joschect joschect commented Apr 12, 2019

Pull request checklist

Description of changes

Details list had an incorrect selector so the highcontrast color was not properly applied when a row was focused.

Before:

image

After:

image

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link
Copy Markdown

size-auditor Bot commented Apr 12, 2019

Bundle test Size (minified) Diff from master
DetailsList 212.097 kB ExceedsBaseline     10 bytes
ShimmeredDetailsList 223.135 kB ExceedsBaseline     10 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

Copy link
Copy Markdown
Member

@KevinTCoughlin KevinTCoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @joschect, thank you!

cc: @natalieethell @Vitalius1

@joschect joschect merged commit ba042b6 into microsoft:master Apr 12, 2019
@msft-github-bot
Copy link
Copy Markdown
Contributor

🎉office-ui-fabric-react@v6.166.1 has been released which incorporates this pull request.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The color contrast ratio for the list items under the card name should be at least 4.5:1

4 participants