Conversation
…remove after testing works.
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a bug where the website deployment workflow was not being triggered after nightly test runs, and adds steps to include Allure test reports in the deployed website. The PR adds "Garnet Nightly Tests" to the workflow_run triggers and implements artifact downloading and copying logic for Allure reports.
Changes:
- Added
continue-on-error: trueto the nightly test job to allow workflow completion even if tests fail - Added "Garnet Nightly Tests" workflow to the deploy-website workflow_run triggers
- Added
if: always()condition to the deploy job to ensure it runs regardless of triggering workflow status - Added steps to checkout allure_data_history branch, download allure-report artifact, and copy Allure reports to the website static folder
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/nightly.yml | Adds continue-on-error: true to allow workflow to complete even with test failures, and removes a blank line |
| .github/workflows/deploy-website.yml | Adds nightly workflow trigger, allure_data_history checkout, artifact download, and Allure report copying steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…g where allure data wasn't fully copied
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…'t fail for non Nightly runs. Fixed path bug too.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
With addition of Allure to the GH website, the website deploy wasn't picking up the allure changes and actually deploying.
One issue with testing it ... the website deploy run only happens after a nightly run is triggered by he schedule and not when run manually triggered.