Fix revivification CLI flag ordering dependency

[hamdaankhalid]

The validation in Options.GetServerOptions() checked the raw enableRevivification flag (from --reviv) instead of the computed useRevivBinsPowerOf2 state. This caused specifying --reviv alongside explicit --reviv-bin-record-sizes and --reviv-bin-record-counts to always fail, despite the --reviv help text documenting that it can be overridden by the combination of these flags.

Changed the check from enableRevivification to useRevivBinsPowerOf2, which correctly reflects that --reviv-bin-record-sizes already overrides the power-of-2 default when present.

[Copilot]

Pull request overview

Fixes revivification CLI flag validation so that --reviv can be combined with explicit --reviv-bin-record-sizes / --reviv-bin-record-counts regardless of argument ordering, matching the documented override behavior.

Changes:

• Update Options.GetServerOptions() validation to check useRevivBinsPowerOf2 (computed state) instead of the raw enableRevivification flag.
• Add a new config-parsing test covering multiple argument orderings for --reviv with explicit bin sizes/counts, plus sizes-only and counts-only scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/Garnet.test/GarnetServerConfigTests.cs	Adds coverage ensuring revivification-related CLI flags parse consistently across multiple argument orderings.
libs/host/Configuration/Options.cs	Adjusts revivification option validation to reflect overridden “power-of-2” behavior when custom bins are provided.

Comments suppressed due to low confidence (1)

libs/host/Configuration/Options.cs:792

• --reviv-bin-record-sizes without --reviv-bin-record-counts is intended to work (defaulting each bin to 256 records per help text/docs). However, RevivBinRecordCounts comes from defaults.conf as null, so when only sizes are provided hasRecordCounts is false and this block is skipped, leaving RevivBinRecordCounts potentially null in GarnetServerOptions. Later, the revivification bin setup code uses RevivBinRecordCounts?.Length switch { 0 => ..., 1 => ..., _ => RevivBinRecordCounts[ii] }, which will hit the _ arm when counts is null and can throw at runtime. Consider normalizing revivBinRecordCounts to an empty array when sizes are specified but counts are not, or updating the downstream switch to treat null the same as length 0.

            if (hasRecordCounts)
            {
                if (useRevivBinsPowerOf2)
                    throw new Exception("Revivification cannot specify both record counts and powerof2 bins.");
                if (!hasRecordSizes)
                    throw new Exception("Revivification bin counts require bin sizes.");
                useRevivBinsPowerOf2 = false;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.