[main] expose VectorSetReplayTaskCount parameter (#1703)#1708
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes a new configuration parameter to control how many tasks are used to replay VectorSet operations on replicas, wiring it through server options, defaults, and test utilities.
Changes:
- Add
VectorSetReplayTaskCountto server options/config (defaults + CLI parsing) and propagate through test cluster/server creation helpers. - Update
VectorManagerto size replay task arrays and locks based on the configured count (with a runtime range check). - Update
GarnetServerto pass fullGarnetServerOptionsintoVectorManager.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Garnet.test/TestUtils.cs | Adds plumbing to pass vectorSetReplayTaskCount into GarnetServerOptions in test helpers. |
| test/Garnet.test.cluster/ClusterTestContext.cs | Exposes vectorSetReplayTaskCount on cluster test context helpers and forwards it to test utilities. |
| libs/server/Servers/GarnetServerOptions.cs | Adds VectorSetReplayTaskCount to the public server options surface. |
| libs/server/Resp/Vector/VectorManager.cs | Uses VectorSetReplayTaskCount to size replay task arrays/locks and adds a runtime range check. |
| libs/host/defaults.conf | Adds default config entry for VectorSetReplayTaskCount. |
| libs/host/GarnetServer.cs | Updates VectorManager construction to accept GarnetServerOptions. |
| libs/host/Configuration/Options.cs | Adds CLI/config option --vector-set-replay-task-count and maps it into GarnetServerOptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevin-montrose
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.