Skip to content

[main] expose VectorSetReplayTaskCount parameter (#1703)#1708

Merged
vazois merged 2 commits intomainfrom
vazois/crp-vset-replay-task-count
Apr 16, 2026
Merged

[main] expose VectorSetReplayTaskCount parameter (#1703)#1708
vazois merged 2 commits intomainfrom
vazois/crp-vset-replay-task-count

Conversation

@vazois
Copy link
Copy Markdown
Contributor

@vazois vazois commented Apr 16, 2026

No description provided.

@vazois vazois marked this pull request as ready for review April 16, 2026 21:07
Copilot AI review requested due to automatic review settings April 16, 2026 21:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Exposes a new configuration parameter to control how many tasks are used to replay VectorSet operations on replicas, wiring it through server options, defaults, and test utilities.

Changes:

  • Add VectorSetReplayTaskCount to server options/config (defaults + CLI parsing) and propagate through test cluster/server creation helpers.
  • Update VectorManager to size replay task arrays and locks based on the configured count (with a runtime range check).
  • Update GarnetServer to pass full GarnetServerOptions into VectorManager.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/Garnet.test/TestUtils.cs Adds plumbing to pass vectorSetReplayTaskCount into GarnetServerOptions in test helpers.
test/Garnet.test.cluster/ClusterTestContext.cs Exposes vectorSetReplayTaskCount on cluster test context helpers and forwards it to test utilities.
libs/server/Servers/GarnetServerOptions.cs Adds VectorSetReplayTaskCount to the public server options surface.
libs/server/Resp/Vector/VectorManager.cs Uses VectorSetReplayTaskCount to size replay task arrays/locks and adds a runtime range check.
libs/host/defaults.conf Adds default config entry for VectorSetReplayTaskCount.
libs/host/GarnetServer.cs Updates VectorManager construction to accept GarnetServerOptions.
libs/host/Configuration/Options.cs Adds CLI/config option --vector-set-replay-task-count and maps it into GarnetServerOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/host/Configuration/Options.cs
Comment thread libs/server/Resp/Vector/VectorManager.cs
Comment thread libs/host/Configuration/Options.cs
Comment thread libs/server/Servers/GarnetServerOptions.cs
@vazois vazois requested a review from kevin-montrose April 16, 2026 21:25
@vazois vazois merged commit e88b91a into main Apr 16, 2026
51 of 53 checks passed
@vazois vazois deleted the vazois/crp-vset-replay-task-count branch April 16, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants