Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Ports a GC-safety fix for InstanceIndexBuffer by switching from explicit-layout/pointer arithmetic to InlineArray with ref-based element access.
Changes:
- Replace explicit-layout
InstanceIndexBufferwith[InlineArray(MaxInstances)]in both LightEpoch implementations - Replace pointer-based element addressing with
Unsafe.Add(ref field0, instanceId) - Annotate byref-return with
[UnscopedRef]to relax ref-escape analysis
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/storage/Tsavorite/cs/src/core/Epochs/LightEpoch.cs | Converts instance index storage to InlineArray and uses ref-based indexing for GC-safety |
| libs/client/LightEpoch.cs | Mirrors the same InlineArray + Unsafe.Add GC-safety change in the client copy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier LightEpoch finding by @kevin-montrose was verified in repro, so porting that fix over.