Merged
Conversation
… more general fix is needed throughout, but this should fix INFO with large numbers of clients or nodes
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates RESP command output to use a new “large” verbatim string writer (for RESP3) and expands existing INFO-related tests to run under both RESP2 and RESP3.
Changes:
- Parameterize INFO/RESETSTATS tests to run for RESP2 and RESP3 configurations.
- Replace verbatim-string output calls in INFO and CLIENT commands to use
WriteLargeVerbatimString. - Implement a new verbatim-string writer that flushes appropriately for larger payloads and uses bulk strings for RESP2.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/Garnet.test/RespInfoTests.cs | Expands test coverage to run INFO/RESETSTATS cases under both RESP2 and RESP3. |
| libs/server/Resp/RespServerSessionOutput.cs | Adds a new verbatim-string writer that handles larger payloads and explicit RESP2/RESP3 behavior. |
| libs/server/Resp/ClientCommands.cs | Switches CLIENTLIST/CLIENTINFO output to the new large verbatim-string writer. |
| libs/server/Metrics/Info/InfoCommand.cs | Switches INFO output to the new large verbatim-string writer and simplifies empty response writing. |
badrishc
approved these changes
May 7, 2026
…b.com/microsoft/garnet into users/kmontrose/verbatimStringFix-dev
badrishc
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devversion of #1776