[DEV] fix: use Stopwatch for INFO durations#1779
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Garnet’s INFO duration reporting to use a monotonic clock (Stopwatch) instead of wall-clock tick deltas, preventing negative/incorrect durations when system time changes (e.g., NTP adjustments). This aligns uptime_in_seconds and master_sync_last_io_seconds_ago with their intended “elapsed time since X” semantics.
Changes:
- Anchor server startup time using
Stopwatch.GetTimestamp()and computeINFO serveruptime viaStopwatch.GetElapsedTime(...). - Track replica primary-sync “last I/O” time with
Stopwatchtimestamps forINFO replication(master_sync_last_io_seconds_ago). - Add a regression test asserting
uptime_in_secondsincreases across successiveINFO SERVERcalls.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Garnet.test/RespInfoTests.cs | Adds a test to validate monotonic uptime across INFO SERVER calls. |
| libs/server/StoreWrapper.cs | Replaces wall-clock startup ticks with a Stopwatch timestamp anchor. |
| libs/server/Metrics/Info/GarnetInfoMetrics.cs | Computes uptime_in_seconds / uptime_in_days using monotonic elapsed time. |
| libs/cluster/Server/Replication/ReplicationManager.cs | Switches replica “last primary sync I/O” duration math to monotonic time. |
badrishc
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devtargeting version of #1771