Rework Vector Set deletion and eviction#1800
Merged
kevin-montrose merged 20 commits intoMay 19, 2026
Merged
Conversation
…ch of work in VectorSessionFunctions, and the whole PendingDeletes key in namespace 1
…ts on marking, recovery just needs to see the context metadata now
…for expiration of Vector Sets
…the counting here - update test to care less about ordering
badrishc
reviewed
May 18, 2026
badrishc
approved these changes
May 18, 2026
badrishc
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework Vector Set deletion and eviction to use
GarnetRecordTriggers.This matches how Range Indexes work, removes the
BADSTATEpossibility, gets aGUIDcomparison out of the hot path, and lays some groundwork for lots of Vector Sets.Concretely:
GarnetRecordTriggers.OnDispose, getting rid of all the cancelled Tsavorite op stuffGUIDstuff for detecting index recreation, instead using theOnEvictandOnDiskReadcallbacks in the same manner as Ranged IndexesRecordTypehandling during copy updates, fixing expirationTODO: