Use bulk string response for VGETATTR#1830
Merged
Merged
Conversation
VGETATTR was using WriteSimpleString to send attribute data. Switch to WriteBulkString (length-prefixed format) which correctly handles arbitrary binary content. This matches Redis behavior -- its RedisModule_ReplyWithString sends a bulk string, not a simple string. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Verifies that attributes containing CR/LF, null bytes, and high bytes are correctly round-tripped through VADD SETATTR and VGETATTR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RESP encoding for the Vector Set VGETATTR response to use a length-prefixed bulk string, making attribute replies binary-safe (e.g., able to include CR/LF, null bytes, and high bytes) and aligning behavior with Redis module reply semantics.
Changes:
- Switch
VGETATTRresponse writing from simple string to bulk string (binary-safe RESP format). - Add a regression test that verifies binary attribute round-trip through
VADD ... SETATTRandVGETATTR.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/server/Resp/Vector/RespServerSessionVectors.cs | Emit VGETATTR attribute data as RESP bulk string instead of simple string to support arbitrary bytes. |
| test/standalone/Garnet.test.vectorset/RespVectorSetTests.cs | Add a test covering binary attribute content (CR/LF, null, high bytes) round-trip via VGETATTR. |
badrishc
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VGETATTR was using \WriteSimpleString\ to send attribute data. This switches to \WriteBulkString\ (length-prefixed format), which correctly handles arbitrary binary content in attributes.
This matches Redis behavior — \RedisModule_ReplyWithString\ sends a bulk string, not a simple string.
Changes