release: move secrets to workflow environment #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions.
vdye
approved these changes
Jun 6, 2023
vdye
left a comment
vdye
left a comment
There was a problem hiding this comment.
Most of the work is "behind the scenes" in the repository settings; the changes here look good.
dscho
pushed a commit
that referenced
this pull request
Jul 7, 2023
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions. An example of a passing `build-git-installers` workflow with these changes can be found [here](https://github.com/ldennington/git/actions/runs/5182147378) (I set up my fork with the same migrated secret values as this repo). Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.
vdye
pushed a commit
that referenced
this pull request
Jul 19, 2023
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions. An example of a passing `build-git-installers` workflow with these changes can be found [here](https://github.com/ldennington/git/actions/runs/5182147378) (I set up my fork with the same migrated secret values as this repo). Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.
dscho
pushed a commit
that referenced
this pull request
Aug 8, 2023
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions. An example of a passing `build-git-installers` workflow with these changes can be found [here](https://github.com/ldennington/git/actions/runs/5182147378) (I set up my fork with the same migrated secret values as this repo). Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.
dscho
pushed a commit
that referenced
this pull request
Aug 8, 2023
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions. An example of a passing `build-git-installers` workflow with these changes can be found [here](https://github.com/ldennington/git/actions/runs/5182147378) (I set up my fork with the same migrated secret values as this repo). Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions.
An example of a passing
build-git-installersworkflow with these changes can be found here (I set up my fork with the same migrated secret values as this repo).Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.