Skip to content

Fix infinite loop in packfile MRU after prefetch packs are added #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+1 −16
Merged

Fix infinite loop in packfile MRU after prefetch packs are added #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb3cf1
fixup! gvfs-helper: create tool to fetch objects using the GVFS Protocol
derrickstolee Nov 18, 2025
13b8048
fixup! packfile: add install_packed_git_and_mru()
derrickstolee Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gvfs-helper-client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ static void gh_client__update_packed_git(const char *line)

p = add_packed_git(the_repository, path.buf, path.len, is_local);
if (p)
packfile_store_add_pack_also_to_mru(the_repository, p);
packfile_store_add_pack(the_repository->objects->packfiles, p);
strbuf_release(&path);
}

Expand Down
8 changes: 0 additions & 8 deletions packfile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,14 +792,6 @@ void packfile_store_add_pack(struct packfile_store *store,
hashmap_add(&store->map, &pack->packmap_ent);
}

void packfile_store_add_pack_also_to_mru(struct repository *r,
struct packed_git *pack)
{
packfile_store_add_pack(r->objects->packfiles, pack);
list_add(&pack->mru,
packfile_store_get_packs_mru(r->objects->packfiles));
}

struct packed_git *packfile_store_load_pack(struct packfile_store *store,
const char *idx_path, int local)
{
Expand Down
7 changes: 0 additions & 7 deletions packfile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,6 @@ void packfile_store_reprepare(struct packfile_store *store);
*/
void packfile_store_add_pack(struct packfile_store *store,
struct packed_git *pack);
/*
* Add the pack to the store so that contained objects become accessible via
* the store, and then mark it as most recently used. This moves ownership into
* the store.
*/
void packfile_store_add_pack_also_to_mru(struct repository *r,
struct packed_git *pack);

/*
* Load and iterate through all packs of the given repository. This helper
Expand Down
Loading