Skip to content

Conversation

@derrickstolee
Copy link

This is a fix for a performance regression introduced by #822. That change updated the packfile installation process to call a different packfile installation method after some upstream changes to the packfile data structures.

However, while I thought I read the new packfile methods as including a modification of the MRU cache, it apparently does not fully install the packfile in the list.

This manifests in something like git checkout where the missing blobs are queued for download, downloaded in blob packfiles, and then the checkout process continues. During the process of writing the data to the worktree, the "updating files" progress indicator slows to a crawl because it was "missing" the blobs and then downloaded them on-demand.

This fixes the issue by being less fancy about packfiles and using packfile_store_reprepare() to just reset the full packfile list. This is more future-proof and isn't very expensive compared to the packfile download.

I augmented a test to include tracing that shows a necessary blob is queued for packfile download and is not later downloaded via an immediate request. Without the code change, that test would fail.

  • This change only applies to interactions with Azure DevOps and the GVFS Protocol.

@derrickstolee derrickstolee requested a review from dscho November 20, 2025 21:28
@derrickstolee derrickstolee self-assigned this Nov 20, 2025
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@dscho dscho merged commit f6415e4 into microsoft:vfs-2.52.0 Nov 21, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants