Simplify VCXProj and add Static Runtime configurations#24
Merged
Conversation
robertos
suggested changes
Apr 25, 2018
| </ProjectConfiguration> | ||
| <ProjectConfiguration Include="Release|ARM"> | ||
| <Configuration>Release</Configuration> | ||
| <Configuration>Release Static Runtime</Configuration> |
Contributor
There was a problem hiding this comment.
I think these should be the not static ones?
Contributor
Author
There was a problem hiding this comment.
Hmm not sure what happened there. I'll fix and re-test compilations
| <IntDir>$(SolutionDir)Built\Int\$(PlatformToolset)\$(Platform)\$(Configuration)\$(MSBuildProjectName)\</IntDir> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'"> | ||
| <PropertyGroup> |
Contributor
There was a problem hiding this comment.
Configuration == Release or Release Static Runtime
Contributor
Author
There was a problem hiding this comment.
The intention was to provide default values and overwrite them for debug, like with the ClCompile group, however I can make this change if you prefer
| @@ -2,27 +2,51 @@ | |||
| <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
Contributor
There was a problem hiding this comment.
You're missing the Solution file change that incorporates these new configs.
robertos
approved these changes
Apr 25, 2018
Contributor
|
OK to merge as soon as the appveyor build/tests succeeds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the VCXProj by replacing Visual Studio's auto-generated properties with a single source of truth and configuration/platform specific overrides.
Also adds the "Static Library" configuration variant to support consumers who want to link the C Runtime statically in their products.