Skip to content

Port missing commits from opensl-fips/openssl #2

Merged
gdams merged 5 commits into
mainfrom
dev/qmuntal/noboots
May 20, 2026
Merged

Port missing commits from opensl-fips/openssl #2
gdams merged 5 commits into
mainfrom
dev/qmuntal/noboots

Conversation

@qmuntal
Copy link
Copy Markdown
Member

@qmuntal qmuntal commented May 20, 2026

No description provided.

dependabot Bot and others added 5 commits May 20, 2026 14:42
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.4 to 4.35.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@68bde55...9e0d7b8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 9a45cc30f671448aef6afc5da24d1c36b8c2a0c2)
* go1.26: fips without enforcement support for hkdf and hmac

Allow setting key-check:0 hmac and kdf param, when executing code
without enforcement. This improves compatibility with go1.26 APIs
allowing to relax enforcement which is required for approved TLS
purposes, as well as to support deprecated, legacy use-cases for
verifying existing calculations.

Also note that PBKDF will start to enforce lower limits, thus
similarly PBKDF should be ported to the EVP KDF APIs to be able to
also set a similar indicator.

Add test case with GODEBUG=fips140only, note that not all test cases
pass under such mode.

* Always set fips params

(cherry picked from commit 93493078e5fcfbea99c160de0a4493294d67e16f)
(cherry picked from commit 87dff5e933fcd887ee44838b697f30955b918f43)
(cherry picked from commit 8ca65ead394b1c8a9981c2a651fdf2e237d1d814)
@qmuntal qmuntal requested a review from gdams May 20, 2026 12:59
@gdams gdams merged commit c0ba8e9 into main May 20, 2026
105 of 111 checks passed
@gdams gdams deleted the dev/qmuntal/noboots branch May 20, 2026 13:04
@github-actions
Copy link
Copy Markdown

Benchmark Results

⚠️ Issues detected — expand failed jobs below for details

azl3-ubuntu-latest-osslsystem-go1.25.x · results
azl3-ubuntu-latest-osslsystem-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.0.13-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.0.13-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.1.5-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.1.5-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.2.1-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.2.1-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.3.1-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.3.1-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.4.0-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.4.0-go1.26.x · results
ubuntu-ubuntu-22.04-ossl3.5.0-go1.25.x · results
ubuntu-ubuntu-22.04-ossl3.5.0-go1.26.x · results
ubuntu-ubuntu-24.04-arm-ossl3.0.13-go1.25.x · results
ubuntu-ubuntu-24.04-arm-ossl3.0.13-go1.26.x · results
ubuntu-ubuntu-24.04-arm-ossl3.1.5-go1.25.x · results
ubuntu-ubuntu-24.04-arm-ossl3.1.5-go1.26.x · results
ubuntu-ubuntu-24.04-arm-ossl3.2.1-go1.25.x · results
ubuntu-ubuntu-24.04-arm-ossl3.2.1-go1.26.x · results
ubuntu-ubuntu-24.04-arm-ossl3.3.1-go1.25.x · results
ubuntu-ubuntu-24.04-arm-ossl3.3.1-go1.26.x · results
ubuntu-ubuntu-24.04-arm-ossl3.4.0-go1.25.x · results
ubuntu-ubuntu-24.04-arm-ossl3.4.0-go1.26.x · results

ubuntu-ubuntu-24.04-arm-ossl3.5.0-go1.25.x

Regressions:

alloc regression: MLDSASign/87-2 [B/op] +0.05% (p=0.000)
alloc regression: MLDSASignExternalMu/87-2 [B/op] +0.03% (p=0.003)

📁 Full results

ubuntu-ubuntu-24.04-arm-ossl3.5.0-go1.26.x

Regressions:

alloc regression: MLDSASign/87-2 [B/op] +0.06% (p=0.001)

📁 Full results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants