Localized file check-in by OneLocBuild Task: Build definition ID 615: Build ID 202935 #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvdeshmukh
approved these changes
Jun 13, 2023
Contributor
apoorvdeshmukh
left a comment
apoorvdeshmukh
left a comment
There was a problem hiding this comment.
To summarize :
As explained in description of this PR, this checks-in final localized resources.
Right now, all of these are copies of English JSON resource but after translation, 'language' and 'Translation' field will be populated with their translation whereas other fields will remain untouched.
The location of these artifacts is intentionally kept different so that existing fields are not impacted. We will integrate these artifacts once we have received translated files and when we automate go generate command.
apoorvdeshmukh
requested changes
Jun 13, 2023
Contributor
There was a problem hiding this comment.
Keeping this merge on hold as generation of drop artifacts for localization team has failed.
The other PR #382 addresses this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.