Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

  • Explore repo structure and understand project organization
  • Create .github/copilot-instructions.md file with comprehensive guidelines
    • Project overview and purpose
    • Complete repository structure documentation (including all internal packages)
    • Build and test instructions
    • Code style and conventions
    • CLI architecture details (Modern Cobra-based and Legacy Kong-based)
    • Configuration management
    • Container support information
    • Localization details
    • Azure authentication information
    • Security considerations
    • Pull request guidelines
    • Common task patterns (separate sections for modern and legacy CLI)
    • CI/CD information
    • Useful resources
  • Run code review tool and address feedback
  • Run codeql_checker for security scan (no code changes detected)
  • Split "Adding a New Subcommand" section into separate sections for modern CLI (context/container/config commands) and legacy CLI (query/display features)
  • Move "Adding a New Configuration Option" under Modern CLI section
  • Enhanced Legacy CLI section with:
    • Guidance to determine if SQLCMD variable should be added
    • Reminder to update README.md with example usage
Original prompt

This section details on the original issue you should resolve

<issue_title>Create a copilot-instructions.md file for go-sqlcmd repo</issue_title>
<issue_description>Prepare the repo for more efficient task and bug fix implementation by Github copilot
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com>
Copilot AI changed the title [WIP] Add copilot-instructions.md file for go-sqlcmd repo Add copilot-instructions.md for go-sqlcmd repository Nov 26, 2025
@shueybubbles
Copy link
Collaborator

@copilot split up the sections about adding new commands and subcommands into separate sections for modern and legacy. We still add features to the legacy when those features are related to querying SQL Server and displaying the query results.

…ions.md

Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot split up the sections about adding new commands and subcommands into separate sections for modern and legacy. We still add features to the legacy when those features are related to querying S...

Split the "Common Tasks" section into separate subsections:

  • "Adding a New Command (Modern CLI)" for context management, container operations, and configuration commands with example code structure
  • "Adding Features (Legacy CLI)" for querying SQL Server and displaying query results, with steps for modifying SQLCmdArguments, setFlags, and related functions

Commit: d18a71e

Copilot AI requested a review from shueybubbles November 26, 2025 03:34
Copilot finished work on behalf of shueybubbles November 26, 2025 03:34
@shueybubbles
Copy link
Collaborator

@copilot the section "### Adding a New Configuration Option" is irrelevant for legacy cli.
For new command line arguments to legacy also consider:

  1. Determine from existing patterns whether to add a SQLCMD variable to support it
  2. Update README.md to show example usage

Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot the section "### Adding a New Configuration Option" is irrelevant for legacy cli.
For new command line arguments to legacy also consider:

  1. Determine from existing patterns whether to add ...

Moved "Adding a New Configuration Option" under Modern CLI (renamed to "Adding a New Configuration Option (Modern CLI)") and updated the Legacy CLI section to include:

  • Step to determine from existing patterns whether to add a SQLCMD variable
  • Step to update README.md to show example usage

Commit: 8e53e79

Copilot finished work on behalf of shueybubbles November 26, 2025 13:53
@shueybubbles shueybubbles marked this pull request as ready for review November 26, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a copilot-instructions.md file for go-sqlcmd repo

2 participants