Fallback to Go crypto when RSA key size is not supported #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Jan 13, 2026
dagood
reviewed
Jan 15, 2026
|
|
||
| - [crypto/rsa](https://pkg.go.dev/crypto/rsa) | ||
|
|
||
| [rsa.GenerateKey](https://pkg.go.dev/crypto/rsa#GenerateKey) only supports the following key sizes (in bits): 2048, 3072, 4096. |
Member
There was a problem hiding this comment.
Was this just a mistake in the doc? Or is this something that was fixed, and is still true for some supported versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go RSA implementation only restricts the minimum RSA key size to 1024 bits (and that can be bypassed by setting (
GODEBUG=rsa1024min=0). It doesn't limit its maximum value and allow sizes not divisible by 8.All out backends have a much stricter RSA key size policy. Take them into account when checking if we have to fallback to Go.
This fixes several compatibility issues with a new FIPS provider being developed in AZL3 and allows to unskip some additional tests.