Simplify yml using pipelineymlgen: container list#2231
Merged
dagood merged 1 commit intomicrosoft/mainfrom Apr 23, 2026
Merged
Conversation
8dd2acb to
7bd030a
Compare
Create pr.gen.yml to generate both pr-pipeline.yml and pr-outerloop-pipeline.yml from a single source, using inlineif for the outerloop vs innerloop differences. Create rolling.gen.yml to generate both rolling-innerloop-pipeline.yml and rolling-pipeline.yml from a single source, using inlineif for the innerloop- specific parameters section and builder flags. Also fix a duplicate entry in variables/codeql.yml.
7bd030a to
4264b4f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces duplication in Azure DevOps pipeline YAML by introducing pipelineymlgen generator inputs and a shared container list, then regenerating the affected pipeline definitions accordingly.
Changes:
- Add
pr.gen.ymlandrolling.gen.ymlgenerator sources to produce the PR and rolling pipelines. - Centralize container image definitions into
eng/pipeline/data/containers.ymland use it to generate both AzDOresources.containersand 1ESextends.parameters.containersformats. - Update the
eng/_utilgo-infradependency to pick up requiredpipelineymlgenimprovements; remove a duplicate CodeQL variable entry.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipeline/variables/codeql.yml | Removes duplicate variable definition. |
| eng/pipeline/rolling.gen.yml | New pipelineymlgen source for rolling inner/outer loop pipelines using shared containers data. |
| eng/pipeline/rolling-pipeline.yml | Regenerated rolling outerloop pipeline with generator header and deduped container mapping. |
| eng/pipeline/rolling-innerloop-pipeline.yml | Regenerated rolling innerloop pipeline with generator header and deduped container mapping. |
| eng/pipeline/pr.gen.yml | New pipelineymlgen source for PR inner/outer loop pipelines using shared containers data. |
| eng/pipeline/pr-pipeline.yml | Regenerated PR innerloop pipeline with generator header and shared containers. |
| eng/pipeline/pr-outerloop-pipeline.yml | Regenerated PR outerloop pipeline with generator header and shared containers. |
| eng/pipeline/data/containers.yml | New shared container/image list used by pipeline generation. |
| eng/_util/go.mod | Bumps github.com/microsoft/go-infra dependency for pipelineymlgen features. |
| eng/_util/go.sum | Updates module sums for the new go-infra version. |
gdams
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and deduplicate some yml using pipelineymlgen.
For the container mapping, relies on pipelineymlgen improvements: