Skip to content

FIPS readme: update to describe no GOFIPS backport#2250

Merged
karianna merged 3 commits into
microsoft/mainfrom
dev/dagood/fips-readme-keep
Apr 29, 2026
Merged

FIPS readme: update to describe no GOFIPS backport#2250
karianna merged 3 commits into
microsoft/mainfrom
dev/dagood/fips-readme-keep

Conversation

@dagood
Copy link
Copy Markdown
Member

@dagood dagood commented Apr 28, 2026

Mainly, try to be as clear as possible about the behavior and that it hasn't changed before 1.27.

Had to split up GOFIPS and GOLANG_FIPS again to handle ordering subtleties. (E.g. GOFIPS=0 takes precedence over GOLANG_FIPS=1.)

This doc uses "Since" rather than "As of" elsewhere, should match.

@dagood dagood requested a review from a team as a code owner April 28, 2026 21:27
Copilot AI review requested due to automatic review settings April 28, 2026 21:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the FIPS documentation to clarify how runtime FIPS mode preference is determined across versions, with emphasis on the GOFIPS/GOLANG_FIPS behavior and the lack of a backport for the GOFIPS bugfix prior to Go 1.27.

Changes:

  • Refines the “Usage: Runtime” precedence list to separately describe GOFIPS vs GOLANG_FIPS and version-specific behavior.
  • Updates the Go 1.25 changelog notes to explain the 1.25/1.26 GOFIPS bug behavior and that the fix was not backported.
  • Adds changelog entries for patch releases noting documentation clarifications.

Comment thread eng/doc/fips/README.md Outdated
Comment thread eng/doc/fips/README.md
Comment thread eng/doc/fips/README.md Outdated
@karianna karianna merged commit 2ef4ece into microsoft/main Apr 29, 2026
59 checks passed
@karianna karianna deleted the dev/dagood/fips-readme-keep branch April 29, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants