Remove TestMachoIssue32233 skip patch#2260
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the downstream patch stack by removing the temporary skip for TestMachoIssue32233 and replacing it with an http2-related skip patch to avoid known FIPS-mode test failures (tracked upstream).
Changes:
- Added a new patch to skip specific HTTP/2-related tests when
crypto/fips140mode is enabled (per golang/go#78557). - Removed the temporary patch that skipped
TestMachoIssue32233(tracked in #2200). - Normalized the patch stack numbering so the HTTP/2 skip is now
0015.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
patches/0015-Skip-http2-tests.patch |
Introduces FIPS-mode skips for selected HTTP/2-related tests to avoid known failures. |
patches/0015-Skip-consistently-failing-TestMachoIssue32233.patch |
Removes the temporary skip of a historically flaky Mach-O test. |
Copilot's findings
- Files reviewed: 2/3 changed files
- Comments generated: 0
qmuntal
force-pushed
the
dev/qmuntal/unskipmachoissue
branch
from
a58c49a to
cf63974
Compare
gdams
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2200
Summary
Validation