Skip to content

Update submodule to latest master in microsoft/main#2263

Merged
bot-for-go[bot] merged 3 commits into
microsoft/mainfrom
dev/auto-sync/microsoft/main
May 6, 2026
Merged

Update submodule to latest master in microsoft/main#2263
bot-for-go[bot] merged 3 commits into
microsoft/mainfrom
dev/auto-sync/microsoft/main

Conversation

@bot-for-go
Copy link
Copy Markdown
Contributor

@bot-for-go bot-for-go Bot commented May 6, 2026

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

…de type arguments in instantiated type cycle errors
@bot-for-go bot-for-go Bot requested review from Copilot and removed request for Copilot May 6, 2026 16:03
Copy link
Copy Markdown

@review-bot-for-go review-bot-for-go Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@bot-for-go bot-for-go Bot enabled auto-merge May 6, 2026 16:03
Copilot AI review requested due to automatic review settings May 6, 2026 16:34
@gdams gdams requested a review from a team as a code owner May 6, 2026 16:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upstream sync PR that refreshes existing patch files to apply cleanly on the updated upstream microsoft/main submodule revision, including a dependency checksum/version bump reflected in the vendor patch.

Changes:

  • Refreshed patch metadata (index hashes / hunk offsets) in 0002-Add-crypto-backend-GOEXPERIMENTs.patch to match new upstream file revisions.
  • Updated module checksum/version content captured in 0001-Vendor-external-dependencies.patch (notably golang.org/x/net), along with associated patch metadata updates.
Show a summary per file
File Description
patches/0002-Add-crypto-backend-GOEXPERIMENTs.patch Patch refresh (index hashes / hunk locations) to align with upstream changes.
patches/0001-Vendor-external-dependencies.patch Vendor/module patch refresh; includes updated module sums/versions and related patch content.

Copilot's findings

Comments suppressed due to low confidence (1)

patches/0001-Vendor-external-dependencies.patch:2304

  • This vendor patch is modifying a non-vendor file (src/go/build/deps_test.go). Per the patch-set consistency rules, 0001-Vendor-external-dependencies.patch should be limited to vendor/ tree changes plus related module files (go.mod/go.sum/modules.txt) and src/crypto/internal/backend/deps_ignore.go. Consider moving the deps_test.go changes into the patch that introduces/uses the backend behavior instead of the vendor patch to keep concerns separated and reduce patch conflicts.
  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@bot-for-go bot-for-go Bot merged commit 426e5f7 into microsoft/main May 6, 2026
58 checks passed
@bot-for-go bot-for-go Bot deleted the dev/auto-sync/microsoft/main branch May 6, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants