Upload msgo/systemcrypto telemetry#2265
Merged
Merged
Conversation
gdams
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated Microsoft telemetry counter for systemcrypto usage so telemetry can continue to measure enablement/disablement after GOEXPERIMENT=systemcrypto is removed (Go 1.27+), and centralizes platform support detection to a reusable helper.
Changes:
- Increment new telemetry counters
msgo/systemcrypto:enabled/msgo/systemcrypto:disabledduringgoinvocation when system crypto is supported for the target platform. - Add
internal/platform.SystemCryptoSupported(goos, goarch)and use it to centralize systemcrypto platform support checks. - Ensure build configuration exposes
SystemCryptoDisabledconsistently for consumers like telemetry.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
| patches/0002-Add-crypto-backend-GOEXPERIMENTs.patch | Introduces internal/platform.SystemCryptoSupported used to determine whether systemcrypto is relevant for a given target. |
| patches/0003-Implement-crypto-internal-backend.patch | Refactors systemcrypto platform support detection in ParseGOEXPERIMENT to use the centralized helper. |
| patches/0009-Add-appinsights-telemetry.patch | Adds msgo/systemcrypto:* counters to the telemetry stats emitted by the go command. |
| patches/0013-Add-Microsoft-version-information.patch | Keeps buildcfg evolution consistent with prior patches; no patch-set consistency issues found related to these changes. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOEXPERIMENT=systemcryptowill disappear in Go 1.27, so we won't be able to use it as a proxy to count systemcrypto usage in telemtry. Use a dedicated counter instead.This implementation is a bit generic to accommodate future systemcrypto refactors.
For #2261