Skip to content

Drop obsolete retain-build placeholder#2277

Merged
dagood merged 1 commit into
microsoft/mainfrom
dev/mclayton/retain-release
May 14, 2026
Merged

Drop obsolete retain-build placeholder#2277
dagood merged 1 commit into
microsoft/mainfrom
dev/mclayton/retain-release

Conversation

@michelle-clayton-work
Copy link
Copy Markdown
Contributor

@michelle-clayton-work michelle-clayton-work commented May 12, 2026

This pull request makes a minor change to the eng/pipeline/stages/run-stage.yml file by removing commented-out code related to retaining builds for the buildandpack configuration. This cleanup helps keep the pipeline YAML more readable and maintainable.

  • Removed commented-out logic for retaining builds when using the buildandpack configuration and a non-nil releaseVersion.

The TODO comment was a marker that 1ES PT migration removed Arcade's retain-build step. The replacement is now in microsoft/go-infra's release pipeline (release-build-steps.yml, after wait-ci-trigger), which discovers the auto-triggered microsoft-go build and pins it externally. The microsoft-go pipeline itself can't gate retention because CI-triggered runs don't carry release parameters; the release pipeline is the only caller that knows it's a release.

See microsoft/go-infra#480.
@michelle-clayton-work michelle-clayton-work force-pushed the dev/mclayton/retain-release branch from 27ec2be to b262e6d Compare May 13, 2026 20:03
@michelle-clayton-work michelle-clayton-work changed the title Add retain build to release pipeline Drop obsolete retain-build placeholder May 13, 2026
@michelle-clayton-work michelle-clayton-work marked this pull request as ready for review May 13, 2026 22:10
Copilot AI review requested due to automatic review settings May 13, 2026 22:10
@michelle-clayton-work michelle-clayton-work requested a review from a team as a code owner May 13, 2026 22:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the Azure DevOps pipeline stage template by removing obsolete, commented-out “retain build” placeholder logic in run-stage.yml, improving readability without changing behavior.

Changes:

  • Removed commented-out conditional YAML that referenced retaining builds for the buildandpack configuration when releaseVersion is set.

@dagood dagood enabled auto-merge (squash) May 13, 2026 22:18
@dagood dagood merged commit 37d1873 into microsoft/main May 14, 2026
62 checks passed
@dagood dagood deleted the dev/mclayton/retain-release branch May 14, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants