Reduce crypto/internal/backend/fips140 API surface#2343
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the crypto/internal/backend/fips140 integration to reduce backend-specific surface area by moving FIPS validation logic into crypto/internal/backend (via a new unexported checkFIPS helper) and updating backend implementations to use it.
Changes:
- Adds
crypto/internal/backend/checkFIPSand rewires backend init-time FIPS validation to call it instead offips140.Check. - Moves
requirefips/ms_skipfipscheckbuild-tag plumbing fromcrypto/internal/backend/fips140intocrypto/internal/backend. - Adjusts
crypto/internal/backend/fips140to expose state needed bycheckFIPS(Message,Require) and removes the previousCheckAPI.
Show a summary per file
| File | Description |
|---|---|
| patches/0002-Add-crypto-backends.patch | Updates the crypto-backends patch to relocate FIPS-checking logic into crypto/internal/backend and revise the fips140 package API accordingly. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
gdams
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto/internal/backend/fips140is intended to be used from upstreamcryptopackages, but there are some APIs that are specific tocrypto/internal/backend, which is not part of upstream.Moving these API to unexported
crypto/internal/backendAPIs will make future refactors easier.