Skip to content

Add copilot instructions for crypto backend implementation#2344

Merged
gdams merged 3 commits into
microsoft/mainfrom
dev/gdams/agent
Jun 3, 2026
Merged

Add copilot instructions for crypto backend implementation#2344
gdams merged 3 commits into
microsoft/mainfrom
dev/gdams/agent

Conversation

@gdams
Copy link
Copy Markdown
Member

@gdams gdams commented Jun 3, 2026

Adds a .github/copilot-instructions.md that captures the architecture patterns, integration conventions, and review guidance for implementing crypto algorithms in the Microsoft Go backend system.

The instructions were derived from:

Covers:

  • End-to-end git go-patch workflow (apply → edit → commit → rebase/squash → extract → verify)
  • Backend shim patterns for all four files (linux/windows/darwin/nobackend)
  • Algorithm integration patterns (gate functions, dispatch, fallback)
  • Build tag and import conventions
  • FIPS 140-only mode enforcement
  • Documentation generation via updatecryptodocs
  • Patch separation rules (vendor in 0001, crypto in 0002)

Add a copilot-instructions.md that captures crypto backend
architecture patterns, integration conventions, and review
guidance derived from @qmuntal's PR reviews. This gives Copilot
the context it needs to implement crypto algorithm integrations
correctly, including the git go-patch workflow, backend shim
patterns, nobackend stub rules, and documentation updates.
@gdams gdams requested a review from a team as a code owner June 3, 2026 09:15
Copilot AI review requested due to automatic review settings June 3, 2026 09:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new .github/copilot-instructions.md intended to guide contributors (and Copilot) when implementing or modifying crypto algorithms in the Microsoft Go “systemcrypto” backend architecture, including the git go-patch workflow, backend shim patterns, gating/dispatch guidance, FIPS 140-only considerations, and doc generation steps.

Changes:

  • Introduces a crypto-backend-focused Copilot instructions document under .github/.
  • Documents the expected git go-patch apply/edit/rebase/extract/commit flow for patch maintenance.
  • Captures backend integration patterns (shims, gates, dispatch, fallback) and related conventions (build tags, import aliasing, doc generation).
Show a summary per file
File Description
.github/copilot-instructions.md Adds repository-specific guidance for crypto backend development workflow and integration conventions.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread .github/copilot-instructions.md Outdated
Comment thread .github/copilot-instructions.md
Comment thread .github/copilot-instructions.md Outdated
@gdams
Copy link
Copy Markdown
Member Author

gdams commented Jun 3, 2026

@qmuntal updated PTAL

@gdams gdams enabled auto-merge (squash) June 3, 2026 11:12
@gdams gdams merged commit 3c48f15 into microsoft/main Jun 3, 2026
54 checks passed
@gdams gdams deleted the dev/gdams/agent branch June 3, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants