[microsoft/release-branch.go1.17] Add "make" retry capability, with 5 in Windows CI#299
Merged
Merged
Conversation
qmuntal
approved these changes
Dec 4, 2021
jaredpar
reviewed
Dec 6, 2021
jaredpar
reviewed
Dec 6, 2021
| - template: ../steps/checkout-windows-task.yml | ||
| - pwsh: | | ||
| Write-Host "Increasing max build retries to mitigate 'Access denied' flakiness during EXE copying on Windows." | ||
| Write-Host "##vso[task.setvariable variable=GO_MAKE_MAX_RETRY_ATTEMPTS]5" |
Member
There was a problem hiding this comment.
Given that we are outputting to stderr now we should be explicit on the failOnStderr property
Member
There was a problem hiding this comment.
Never mind that is fmt.ErrorF not printing to stderr 😦
jaredpar
approved these changes
Dec 6, 2021
qmuntal
approved these changes
Dec 6, 2021
dagood
added a commit
that referenced
this pull request
Jan 27, 2022
… in Windows CI (#299) * Add "make" retry capability, with 5 in Windows CI * Report error if GO_MAKE_MAX_RETRY_ATTEMPTS is not an int
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry on the
make.batcalls in CI to mitigate flakiness:Submitting directly to 1.17 because this flakiness has only been seen here. This is nice: we can mitigate it while avoiding masking other potential flakiness issues in
microsoft/mainand the other release branches.In this test build, we got up to three attempts in one job before success, and all 20 jobs succeeded building: https://dev.azure.com/dnceng/internal/_build/results?buildId=1496055&view=results