[microsoft/dev.boringcrypto.go1.16] Rearrange FIPS patches, start at 0100#513
Merged
dagood merged 1 commit intoMar 31, 2022
Conversation
Make adding crypto/internal/backend and importing the OpenSSL library happen in the same patch. Put repo-spanning boring -> OpenSSL changes in its own patch. Put the vendoring patch after the patch that adds the OpenSSL dependency, for simpler regeneration. Bring test adjustments/fixes together into the final patch.
This was referenced Mar 31, 2022
qmuntal
approved these changes
Mar 31, 2022
Member
Author
|
After the renumbering, you need this git-go-patch update to be able to round-trip the patch files: |
chsienki
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts with the same set of FIPS patch layering improvements as:
Then adds in a renumbering command so the infra (1.16) patches start at 0001 and FIPS patches start at 0100.
I ran the same check as I did there: diff before and after shows zero changes.