[microsoft/release-branch.go1.19] Cherry-pick: Move CodeQL to validation pipeline, keep patch check in Actions#844
Merged
Conversation
(cherry picked from commit 208aed9)
qmuntal
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 1.19.5 release process, the GitHub Actions CodeQL check failed due to some flakiness, so I had to manually re-run it. This change removes that check in favor of running CodeQL internally in a way that won't block releases if that kind of flakiness happens again.
This PR isn't blocking 1.19.5, and I only plan to merge it after 1.19.5 is out the door.
(
I'm only planning to port this to 1.19, not 1.18, because 1.18 will be out of support relatively soon and I haven't seen this flakiness there.After posting this PR, I saw that it happened on 1.18-fips as well.)