Conversation
pavelglac
approved these changes
Jan 31, 2025
| }, | ||
| mergePolicies: new Map(), | ||
| readPolicies: new Map(), | ||
| autoEvict: config?.autoEvict ?? true, |
Contributor
There was a problem hiding this comment.
nitpick: Would be nice to have it sorted alphabetically someday
Contributor
Author
There was a problem hiding this comment.
Maybe someday :) I prefer having related options grouped together - so if we sort alphabetically we will need to rename them to have a common prefix for the same "group" (or introduce another level of objects for grouping). Which is a breaking change.
| const cache = new ForestRun({ | ||
| maxOperationCount: 1, | ||
| autoEvict: false, | ||
| nonEvictableQueries: new Set(["b"]), // root-level field |
Contributor
There was a problem hiding this comment.
question: maxOperationCount is actually increased by length of nonEvictableQueries, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today ForestRun does automatic data eviction when the number of operation exceeds
maxOperationResultoption. This PR introduces anautoEvictoption which allows disabling automated eviction and instead control when data eviction kicks in withgcmethod from Apollo cache interface.Related options:
autoEvict: defaulttruemaxOperationCount: default1000