Remove lancedb_dir redundant assignments#1163
Merged
AlonsoGuevara merged 2 commits intomicrosoft:mainfrom Sep 19, 2024
Merged
Conversation
AlonsoGuevara
approved these changes
Sep 19, 2024
opensourcemukul
pushed a commit
to opensourcemukul/graphrag
that referenced
this pull request
Sep 13, 2025
Co-authored-by: wanhua.gu <wanhua.gu@wiz.ai> Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
Brandsma
pushed a commit
to ThalamusLabs/MMGraphRAG
that referenced
this pull request
Nov 6, 2025
Co-authored-by: wanhua.gu <wanhua.gu@wiz.ai> Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lancedb_dir = lancedb_dir = Path(config.storage.base_dir) / "lancedb"
=> lancedb_dir = Path(config.storage.base_dir) / "lancedb"
Related Issues
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context that may be helpful for the reviewer(s).]