Cleanup factory methods #1482
Merged
Cleanup factory methods #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonsoGuevara
approved these changes
Dec 10, 2024
3 tasks
opensourcemukul
pushed a commit
to opensourcemukul/graphrag
that referenced
this pull request
Sep 13, 2025
* cleanup factory methods to have similar design pattern across codebase * add semversioner file * cleanup logging factory * update developer guide * add comment * typo fix * cleanup reporter terminology * renmae reporter to logger * fix comments * update comment * instantiate factory classes correctly and update index api callback parameter --------- Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
Brandsma
pushed a commit
to ThalamusLabs/MMGraphRAG
that referenced
this pull request
Nov 6, 2025
* cleanup factory methods to have similar design pattern across codebase * add semversioner file * cleanup logging factory * update developer guide * add comment * typo fix * cleanup reporter terminology * renmae reporter to logger * fix comments * update comment * instantiate factory classes correctly and update index api callback parameter --------- Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consist of multiple cleanup changes, mostly focused on the factory methods/classes across the codebase.
Checklist
Notes
I will create a separate PR later that truly updates/refactors all the reporter terminology as it is more invasive and touches more files. This is with the eventual goal in mind to merge the ProgressLogger/ProgressReporter classes together with the PipelineReporter classes so that we have a single source for logging in the codebase instead of two.