fix(query): ensure nodes missing level attributes are included in context#2333
Open
EaCognitive wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(query): ensure nodes missing level attributes are included in context#2333EaCognitive wants to merge 1 commit intomicrosoft:mainfrom
EaCognitive wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1808
Problem
In GraphRAG's query engine, the
_filter_under_community_levelutility aggressively filters out any nodes that are missing thelevelattribute. This happens because pandas comparisondf.level <= community_levelreturnsFalseforNaNorNonevalues, causing these nodes to be silently dropped from the query context. This leads to incomplete or hallucinated answers.Solution
Updated the filtering logic to explicitly include nodes where the
levelattribute isNaN. This ensures that all relevant graph data is considered during query execution, regardless of metadata completeness.Changes
packages/graphrag/graphrag/query/indexer_adapters.py: Updated_filter_under_community_levelto handleNaNvalues gracefully.Verification