chore(e2e): use explicit workspace deps for internal @griffel/* packages#962
Closed
layershifter wants to merge 1 commit into
Closed
chore(e2e): use explicit workspace deps for internal @griffel/* packages#962layershifter wants to merge 1 commit into
layershifter wants to merge 1 commit into
Conversation
First slice of the larger workspaces + project-references migration. This one only touches private packages — the published @griffel/* packages keep their path aliases in tsconfig.base.json untouched. - e2e/eslint, e2e/typescript: add @griffel/e2e-utils as devDependency (workspace:*). Both already import from @griffel/e2e-utils; the resolution was implicit via the path alias. - e2e/rspack: tighten the existing "*" e2e-utils dep to workspace:* for consistency. - Drop @griffel/e2e-utils and @griffel/update-shorthands aliases from tsconfig.base.json — no consumer needs them now that the deps are declared explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📊 Bundle size report✅ No changes found |
4 tasks
Member
Author
|
Slicing the migration into phases doesn't pan out — closing in favor of the single migration in #774. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of the larger workspaces + project-references migration explored in #774. This PR is intentionally minimal — it only touches private packages so it can land independently:
e2e/eslint,e2e/typescript: add@griffel/e2e-utilsasdevDependency(workspace:*). Both already import from@griffel/e2e-utils; the resolution was implicit via the path alias intsconfig.base.json.e2e/rspack: tighten the existing"*"e2e-utilsdep toworkspace:*for consistency.@griffel/e2e-utilsand@griffel/update-shorthandsaliases fromtsconfig.base.json— no consumer needs them now that the deps are declared explicitly.Published
@griffel/*packages keep their path aliases untouched; those migrate in follow-up PRs.Test plan
yarn nx run-many --target=type-check --all— passes (20/20)yarn nx run @griffel/e2e-eslint:test— passesyarn nx run @griffel/e2e-typescript:test— passesyarn check-dependencies— clean🤖 Generated with Claude Code