oc/exporter: Include the name of a span in the message#2470
Merged
Conversation
helsaawy
approved these changes
Jul 10, 2025
anmaxvl
approved these changes
Jul 10, 2025
Contributor
anmaxvl
left a comment
anmaxvl
left a comment
There was a problem hiding this comment.
lgtm. checked with D&I and they also in favor of this change. thanks!
micromaomao
force-pushed
the
tingmao/span-message
branch
from
ce80c7e to
b3c0462
Compare
Member
Author
|
No change rebase as requested by @anmaxvl |
Member
Author
|
@anmaxvl can we merge this? |
micromaomao
force-pushed
the
tingmao/span-message
branch
from
b3c0462 to
ec33da1
Compare
jterry75
reviewed
Aug 14, 2025
Contributor
jterry75
left a comment
jterry75
left a comment
There was a problem hiding this comment.
I'm worried this will break queries. Do we ever use type Span .Name -eq Thing in queries?
Member
Author
This doesn't change the Name of a span log, it only changes the log body itself, which previously was always "Span". |
micromaomao
force-pushed
the
tingmao/span-message
branch
from
ec33da1 to
1828862
Compare
This makes it easier to read the logs and see which spans are there, especially since WPA sorts the field by its name, independently for each row. Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
micromaomao
force-pushed
the
tingmao/span-message
branch
from
1828862 to
61d281a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to read the logs and see which spans are there, especially since WPA sorts the field by its name, independently for each row.
see:
versus
I've discussed with Maksim. His worry is that DRIs might already be filtering out rows based on this string, but I think this is still worth considering.