WCOW: restore support for client-mounted roots with process-isolated containers #2595
+58
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 00ca088 broke starting process-isolated containers when Root.Path is set in the container spec. Root.Path is set by clients such as Docker which mount and unmount the container's root filesystem themselves. Mounting is skipped, which also skips over setting coi.mountedWCOWLayers. The hcsoci.createWindowsContainerDocument function unconditionally dereferences that field, resulting in a nil-dereference panic when mounting is skipped. Restore the old behaviour by synthesizing the MountedWCOWLayers when Root.Path is set. Signed-off-by: Cory Snider <csnider@mirantis.com>
Contributor
|
@ambarve PTAL - this unblocks us with running docker with containerd 2.2 ❤️ |
anmaxvl
approved these changes
Feb 5, 2026
helsaawy
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createWindowsContainerDocumentwhen starting container with process isolation #2488#2029 broke starting process-isolated containers when
Root.Pathis set in the container spec.Root.Pathis set by clients such as Docker which mount and unmount the container's root filesystem themselves. Mounting is skipped, which also skips over settingcoi.mountedWCOWLayers. Thehcsoci.createWindowsContainerDocumentfunction unconditionally dereferences that field, resulting in a nil-dereference panic when mounting is skipped. Restore the old behaviour by synthesizing theMountedWCOWLayerswhenRoot.Pathis set.