[shimV2] refactor VM controller + network controller#2690
Merged
rawahars merged 1 commit intomicrosoft:mainfrom Apr 17, 2026
Merged
[shimV2] refactor VM controller + network controller#2690rawahars merged 1 commit intomicrosoft:mainfrom
rawahars merged 1 commit intomicrosoft:mainfrom
Conversation
This was
linked to
issues
Apr 17, 2026
Earlier, we created the HCS document in the service layer and then passed that along to the VM Controller in Create call. This also leaks other VM options such as confidential, etc into service layer which can be encapsulated within the VM Controller. Basically, service sends the specs to `vmController.Create`. It calls the LCOW or WCOW tagged file to generate the HCS document and sandbox options which it stores internally. Next during Start it references the same to create Confidential stack. For other cases such as Network controller etc, it can use the same. Also, refactored Network controller to include the namespace and policy option as part of the New call. Start will not have any options as of now. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
network_controller_refactor
branch
from
bc2c504 to
dc2c564
Compare
jterry75
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, we created the HCS document in the service layer and then passed that along to the VM Controller in Create call. This also leaks other VM options such as confidential, etc into service layer which can be encapsulated within the VM Controller.
Basically, service sends the specs to
vmController.Create. It calls the LCOW or WCOW tagged file to generate the HCS document and sandbox options which it stores internally. Next during Start it references the same to create Confidential stack.For other cases such as Network controller etc, it can use the same.
Also, refactored Network controller to include the namespace and policy option as part of the New call. Start will not have any options as of now.