Adds live migration ttrpc service definition#2691
Merged
rawahars merged 3 commits intomicrosoft:mainfrom Apr 21, 2026
Merged
Conversation
apurv15
reviewed
Apr 17, 2026
rawahars
force-pushed
the
lm-proto
branch
2 times, most recently
from
fad0072 to
b5536db
Compare
apurv15
reviewed
Apr 20, 2026
rawahars
force-pushed
the
lm-proto
branch
2 times, most recently
from
1e69da8 to
71cd5d4
Compare
Introduces the Live Migration ttrpc service with RPCs for preparing, transferring memory, and finalizing sandbox live migration between source and destination hosts. Includes sandbox state serialization for cross-host config propagation. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
jterry75
requested changes
Apr 20, 2026
|
|
||
| message TransferSandboxResponse { | ||
| // Increments per message; can be used to dedupe after client restarts. | ||
| uint32 message_id = 1; |
Contributor
There was a problem hiding this comment.
Are you buffering them? How would the client obtain messages after it restarts?
Contributor
Author
There was a problem hiding this comment.
No, we do not buffer them. The behaviour as discussed with Apurv was to just return the last message in case of restart.
Contributor
There was a problem hiding this comment.
Let's not do that. But we can merge this as is for now.
jterry75
approved these changes
Apr 20, 2026
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
jterry75
approved these changes
Apr 20, 2026
apurv15
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new live migration service to the codebase, including its protocol definitions, generated Go bindings, and integration into the project configuration. The migration service manages sandbox live migration workflows, handling preparation, memory transfer, and finalization.
Live migration service introduction:
migrationpackage, including proto definitions (migration.proto) for the live migration service, which defines the migration workflow (preparation, memory transfer, finalization, and socket duplication) and all related messages and enums.migration_ttrpc.pb.go) for the migration service, providing server and client interfaces for use in Go code.migrationpackage indoc.go.migrationpackage in theProtobuild.tomlfile, ensuring proto code generation for the package.