[LinAlg spec change] Update vector sizes on Multiply* to match column-vector multiplication#843
Merged
Merged
Conversation
…atch matrix x colunm-vector multiplication
hekota
changed the title
hekota
changed the title
tex3d
approved these changes
Apr 3, 2026
Collaborator
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
I think this all looks correct, but I can get things backwards easily, so multiple people should probably verify.
jenatali
approved these changes
Apr 3, 2026
Member
jenatali
left a comment
jenatali
left a comment
There was a problem hiding this comment.
Minor wording fixes but the meat looks right.
Contributor
|
The godbolt link in the spec was not updated to include the updates to the appendix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix-vector APIs should be aligned with coopvec, meaning the multiplication would be matrix x column-based vector.
This was originally done in #741 but somehow got mostly reverted.