-
Notifications
You must be signed in to change notification settings - Fork 286
Investigating torch==1.10 #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 90.59% 84.79% -5.81%
==========================================
Files 78 78
Lines 4540 4544 +4
Branches 940 941 +1
==========================================
- Hits 4113 3853 -260
- Misses 240 499 +259
- Partials 187 192 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…king for torch==1.10
|
Ok generating the new model with static dims makes the tests pass locally, but the test still hangs locally (meaning it prints the "warnings" summary", and also hangs in the pipeline. Ex: test_extra_conf.py ........sssss............ssssssssssss [100%]
========== warnings summary ===========================================
../../.local/lib/python3.7/site-packages/onnx/mapping.py:27
/home/kasaur/.local/lib/python3.7/site-packages/onnx/mapping.py:27: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
int(TensorProto.STRING): np.dtype(np.object)
../../.local/lib/python3.7/site-packages/sklearn/experimental/enable_hist_gradient_boosting.py:17
/home/kasaur/.local/lib/python3.7/site-packages/sklearn/experimental/enable_hist_gradient_boosting.py:17: UserWarning: Since version 1.0, it is not needed to import enable_hist_gradient_boosting anymore. HistGradientBoostingClassifier and HistGradientBoostingRegressor are now stable and can be normally imported from sklearn.ensemble.
"Since version 1.0, "
-- Docs: https://docs.pytest.org/en/stable/warnings.html
======= 20 passed, 17 skipped, 2 warnings in 7.08s =========================================and then......hangs....forever. That was a new one. I am not sure what to try next. It only behaves this way for torch==1.10 on onnx tests on linux/mac. Passes everything on Windows. Passes everything if torch <1.10. |
| classes_conv = torch.from_numpy(np.array(sorted(set(classes)), dtype=data_type).view(np.int32)).detach().clone() | ||
| classes_conv = classes_conv.view(1, -1, self.max_word_length) | ||
|
|
||
| self.condition_tensors = torch.nn.Parameter(torch.IntTensor(classes_conv), requires_grad=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are at it, can you also please remove torch.IntTensor. It is not necessary here anymore.
Runs ok locally; let's check the pipeline.