fix(scripts): Exclude plugins/ from ms.date freshness check to prevent duplicate stale reports#1586
Merged
Conversation
… check 🐛 - Generated by Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
- Coverage 85.50% 85.49% -0.01%
==========================================
Files 82 82
Lines 11805 11805
==========================================
- Hits 10094 10093 -1
- Misses 1711 1712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
WilliamBerryiii
approved these changes
May 14, 2026
bindsi
approved these changes
May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Invoke-MsDateFreshnessCheck.ps1script was scanning symlinked markdown files in theplugins/directory, causing duplicate stale documentation reports. This happened becauseGet-ChildItem -Recursefollows symlinks on Linux, and all 532 markdown files underplugins/are symlinked mirrors of collection-generated content from source locations elsewhere in the repository.This fix adds
pluginsto the exclusion patterns in the freshness check script, following the same pattern already established inValidate-MarkdownFrontmatter.ps1. The change eliminates the duplicate scanning and prevents downstream workflows from creating multiple GitHub issues for the same underlying stale documentation source.Impact of the fix:
plugins/Related Issue(s)
Fixes #1585
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
Added comprehensive test coverage in
scripts/tests/linting/Invoke-MsDateFreshnessCheck.Tests.ps1:plugins/directory structure.copilot-tracking,logs, and other directoriesGet-MarkdownFilesproperly filters out files in the plugins pathRun tests locally:
Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generatenpm run docs:testSecurity Considerations
Additional Notes
Get-ChildItem -Recurseon Linux follows symlinks, causing all files underplugins/to be scanned despite their symlinked natureInvoke-MsDateFreshnessCheck.ps1behavior withValidate-MarkdownFrontmatter.ps1, which already excludesplugins/**