-
Notifications
You must be signed in to change notification settings - Fork 36
fix(build): increase release-please search depths to prevent 250-commit window issue #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…it window issue - add release-search-depth (800) and commit-search-depth (1000) at root level - add explicit include-component-in-tag setting to match existing tag format 🔧 - Generated by Copilot
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 52.44% 52.41% -0.04%
==========================================
Files 17 17
Lines 3110 3110
==========================================
- Hits 1631 1630 -1
- Misses 1479 1480 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a release-please configuration issue where the tool fails to detect version tags beyond its default ~250 commit scanning window, causing it to incorrectly reprocess the entire commit history and detect already-released breaking changes.
Changes:
- Added search depth configurations (
release-search-depth: 800,commit-search-depth: 1000) to expand release-please's commit scanning window - Added explicit tag format configuration (
include-component-in-tag: true) to match the existinghve-core-vX.Y.Ztag pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Description
Configure release-please search depths to prevent version detection failures when the latest release tag is beyond the default commit scanning window. This addresses a known limitation (googleapis/release-please#2267) where release-please fails to find tags older than ~250 commits, causing it to reprocess the entire commit history and incorrectly detect already-released breaking changes.
release-search-depth: 800at root level to increase release pagination depthcommit-search-depth: 1000at root level to increase commit scanning depthinclude-component-in-tag: trueto explicitly match the existing tag format (hve-core-vX.Y.Z)Related Issue(s)
Related to googleapis/release-please#2267
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
N/A - This is a configuration fix, not an AI artifact contribution.
Testing
node -e "require('./release-please-config.json')"Checklist
Required Checks
AI Artifact Contributions
N/A
Required Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run lint:md-linksnpm run lint:psSecurity Considerations
Additional Notes
This fix addresses the erroneous v3.0.0 release PR (#341) that was created immediately after publishing v2.0.1. The root cause was the 250-commit window limitation causing release-please to reprocess the entire commit history and re-detect the breaking change from PR #277 that was already released in v2.0.0.
🔧 - Generated by Copilot