igvm_c: switch Makefile to cargo-c #94
Merged
+31
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not include the .h files on the command line; do not include the library twice, once via $^ and once via -ligvm. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Contributor
Author
|
@microsoft-github-policy-service agree company="Red Hat, Inc." |
bonzini
force-pushed
the
cargo-c
branch
2 times, most recently
from
ef1f374 to
202c9b6
Compare
cargo-c is able to generate a shared library and takes care of creating the .pc file as well. The main change that is needed for the Makefile is that libraries are placed in a subdirectory of the CARGO_TARGET_DIR. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The Rust runtime dependencies may vary depending on the target. cargo-c is able to place them in the .pc file, and also builds a .pc file that can be used before installation. This fixes cross compilation under Windows, which can be done with make -C igvm_c CARGO_BUILD_TARGET=x86_64-pc-windows-gnu EXTRA_PARAMS="--target x86_64-pc-windows-gnu" CC=x86_64-w64-mingw32-gcc Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This finally makes it possible to *install* a cross-compiled Windows build, albeit with a manual "EXE=.exe" on the command line. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Contributor
Author
|
Successful CI run at https://github.com/bonzini/igvm/actions/runs/16916292363 |
Member
|
Neat, thanks for the contribution. I've set it to automerge. |
chris-oo
changed the title
chris-oo
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cargo cbuildandcargo cinstallhas various advantages:it is able to generate a shared library (
cdylib- this is important because if you have two dependencies that are Ruststaticlibs, they final link will fail due to duplicate symbols)it takes care of generating the
.pcfile and correctly includes the dependencies of the Rust standard library. This makes it possible to cross-compile not justlibigvm, but alsodump_igvm, and to easily link with the staticlibigvm.aafter they've been installed into$(DESTDIR)/$(PREFIX).