Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@Feiryn thanks for adding the ARM support! For 12 bytes patching size that is an issue should be handled by a sanitizing check to avoid undefined behavior. But for now since amd64 and aarch64 both have the same issue, I would not try to solve it in this PR. I have created an issue to track it: #95 I'll start to review the change soon. Probably next week. Thanks for the contribution! |
|
LGTM. @Feiryn thanks for making the support for ARM! |
|
Hi @mazong1123, do you plan to release the new features soon? |
Hi, yes next week a new release will be shipped. The ARM support will be included. |
|
@Feiryn I have drafted a beta release https://github.com/microsoft/injectorppforrust/releases/tag/v0.5.0-beta.1. The official release still needs quite some time for preparation. Hope this can unblock you. |
I added ARM support for both ARM and Thumb modes.
The only part I'm not 100% sure of is the patch size.
I don't really know if 12 bytes is too large and can overwrite code outside of the patched function in some really specific cases, like a really small function that precedes the target function.