Increase MAX_NUM_HOOKS from 64 to 128 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfoukas
requested changes
May 12, 2025
Collaborator
xfoukas
left a comment
xfoukas
left a comment
There was a problem hiding this comment.
Please increase to a power of 2 instead (128).
matthewbalkwill
changed the title
xfoukas
approved these changes
May 14, 2025
Collaborator
|
I think this should be merged to |
matthewbalkwill
added a commit
that referenced
this pull request
May 15, 2025
* Add helper function for fixed points (#71) * Add helper function for fixed points * Addressing the comments * Revert * Continued work * Fix the algorithms and tests * Minor tweaks * Cleanup * Avoid clang optimise the code * Fix implementations * Test fixed_to_float and fixed_to_double * Fix type * Add 2 more tests * Cleanup * Clang format inconsistent fix * Add more tests in the codelet * Increase MAX_NUM_HOOKS from 64 to 128 (#90) * Increase MAX_NUM_HOOKS from 64 to 96 * Increase MAX_NUM_HOOKS to 128 --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Add helper function for fixed points (#71) * Add helper function for fixed points * Addressing the comments * Revert * Continued work * Fix the algorithms and tests * Minor tweaks * Cleanup * Avoid clang optimise the code * Fix implementations * Test fixed_to_float and fixed_to_double * Fix type * Add 2 more tests * Cleanup * Clang format inconsistent fix * Add more tests in the codelet * Increase MAX_NUM_HOOKS from 64 to 128 (#90) * Increase MAX_NUM_HOOKS from 64 to 96 * Increase MAX_NUM_HOOKS to 128 --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com>
doctorlai-msrc
added a commit
that referenced
this pull request
Jun 2, 2025
* Add helper function for fixed points (#71) * Add helper function for fixed points * Addressing the comments * Revert * Continued work * Fix the algorithms and tests * Minor tweaks * Cleanup * Avoid clang optimise the code * Fix implementations * Test fixed_to_float and fixed_to_double * Fix type * Add 2 more tests * Cleanup * Clang format inconsistent fix * Add more tests in the codelet * Increase MAX_NUM_HOOKS from 64 to 128 (#90) * Increase MAX_NUM_HOOKS from 64 to 96 * Increase MAX_NUM_HOOKS to 128 --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com>
xfoukas
added a commit
that referenced
this pull request
Jun 2, 2025
* Add branch instructions in CONTRIBUTING.md and Update ADO pipeline triggers (#78) * Add Github Action Pipeline and Fixed INITIALIZE_SUBMODULES (#64) * Add Debug build configuration testing to CI pipeline (#57) --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: Xenofon Foukas <137962+xfoukas@users.noreply.github.com> * Add helper function for fixed points (#71) (#85) Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> * Fixes for tests to pass when cmake build type is Release (#86) This fixes issue #79. When the cmake build type is not defined it defaults to Release. Given that the tests rely on assert() to pass, the PR also undefs NDEBUG in the release build flags to prevent the optimizer from removing the assert() calls. * Improve Validation Error Messages in Linked Map (#82) * Matt/dev: MAX_NUM_HOOKS to 128 (#91) * Add helper function for fixed points (#71) * Increase MAX_NUM_HOOKS from 64 to 128 (#90) --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> * Refactor run_lcm_subproc by removing memory allocation with new/delete. (#93) * Fix build/package error in ubuntu22.04 (#96) * Add native support for ARM builds (#59) --------- Co-authored-by: Zhihua Lai <zhihualai@microsoft.com> Co-authored-by: Xenofon Foukas <137962+xfoukas@users.noreply.github.com> Co-authored-by: Connor Settle <connorsettle@microsoft.com> Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> * Bugfix: perf time measurement API with invalid times (#102) * Bump ubpf to the latest version (#103) * Matt/issue94 (#95) * Remove ado correctness + move to cloud agents (#100) * Sync dev with main (#105) * Add helper function for fixed points (#71) * Increase MAX_NUM_HOOKS from 64 to 128 (#90) --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com> --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: Xiaochuan Ye <tap91624@gmail.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com> Co-authored-by: Anita Tenjarla <anita-tenjarla@users.noreply.github.com> Co-authored-by: Zhihua Lai <zhihualai@microsoft.com> Co-authored-by: Connor Settle <connorsettle@microsoft.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Adding a emulator * Add Python/ctypesgen dependencies for emulator * Add jbpf_agent_hooks.h and generate py * Add time helper functions * Test emulator * Add missing file * Add missing fields * Fix time event initialization * Refactor * Remove protobuf, update jbpf_stats_report.o * Add xran helper functions, and create random stream_id * Clang-format * Fix cppcheck issue * Refactor default values * Default num_codelet_descriptors to len(codelet_descriptors) * Enable ASAN in tests, ignore ODR, cleanup * Clangformat * Support custom helper functions and refactor * Fix clang-format * Move definitions above users include file * Remove XRAN * Add Custom init code * Add yaml_to_json, refactor * Fix path * Add debug option to emulator_utils.jbpf_handle_out_bufs * Match codelet_descriptor in yaml * Add missing define agent hooks * Revert * jbpf_handle_out_bufs should return how many messages that have been processed * Add some debug output when calling periodic_call and report_stats hook * Add a test to make sure the report_stats is actually called * Add comment * Clang-format -i * Add debug printf * Continued work * Add matching ck_epoch_end * Clang * Continued testing * Add more debugging * Clang * Debug * Debug print * Add more debugging message * More debugging * Add tests for report_stats and periodic_call, add debugging * Clang-format * Pipeline integration * simple_output2.o * Add missing files * Refactor & debug * COntinued work * Continued work * Revert and Cleanup * Revert * Fix * Ignore dynamic builds * Fix * Fix syntax * Fix syntax * Keep static mode only * Revert * Emulate time and add a test * Add test * Fix clang-format * Add missing file * Fix compilation under ubuntu20 * Init draft of adding both options * Fix * Pipeline * Move autogen wrappers * Fix cppcheck issue * Build both by default * Fix JBPF_SHARED_LIB * Fix build under ubuntu24.04 * Fix segfault at Static * Add emulator tests to github action, fix RELEASE * Typo * First round of addressing comments * Improve test description comments * Add some more doc * Add to ARM pipeline * Sync dev with main (#105) * Add helper function for fixed points (#71) * Add helper function for fixed points * Addressing the comments * Revert * Continued work * Fix the algorithms and tests * Minor tweaks * Cleanup * Avoid clang optimise the code * Fix implementations * Test fixed_to_float and fixed_to_double * Fix type * Add 2 more tests * Cleanup * Clang format inconsistent fix * Add more tests in the codelet * Increase MAX_NUM_HOOKS from 64 to 128 (#90) * Increase MAX_NUM_HOOKS from 64 to 96 * Increase MAX_NUM_HOOKS to 128 --------- Co-authored-by: Zhihua Lai <92519564+doctorlai-msrc@users.noreply.github.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com> * Refactor docker files * Add to github actions * Add System Information * Merge and fix * Fix comments * Readme * More doc * Update docs * Move emulator tests to the end * Add debug messages * Add more debug * Update codelet to provide more information * Comment * Fix print error * Revert "Update codelet to provide more information" This reverts commit 95dc9e4. * Fix segfault * Use smart ptr * Revert "Adding a emulator" * Revert "Enable Building Both libjbpf.a and libjbpf.so with cmake option -DJBPF_STATIC=Both" --------- Co-authored-by: Xenofon Foukas <137962+xfoukas@users.noreply.github.com> Co-authored-by: matthewbalkwill <93522480+matthewbalkwill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current number of hooks is too low.
Increasing to 128.