fix(keyborg): Multiple bundles should not override instances#104
Open
mathis-m wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(keyborg): Multiple bundles should not override instances#104mathis-m wants to merge 2 commits intomicrosoft:mainfrom
mathis-m wants to merge 2 commits intomicrosoft:mainfrom
Conversation
2 tasks
Author
|
@miroslavstastny @mshoho @Hotell please have a look at this. It's open for 4months now. We at Avanade are depending on this, this has impact on MSTF products such as D365 when using PCF components. Having a PR stale for so long is really not appreciated. Thanks |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Not sure about #75 as it is stale for so long, that is why I have taken it up myself:
To provide backwards compatibility: prefix changed from:
c=>c_k=>k_Id is now synced via the global window object.
Hence:
New Ids with underscore in the id will not collide as the number is synced over the window and JS is single thread.
Old code wont override the new ids because of the underscore.
Outlook:
In general this topic needs to be revisited to ensure that the refs and core instances are grouped by version.
eg: