Throw error on https:// and http:// prefix if present in allowed host value
#461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host value Fixes microsoft#201 Add error handling for 'https://' and 'http://' prefixes in allowed host values. * Modify `AllowedHostsValidator` class in `packages/abstractions/kiota_abstractions/authentication/allowed_hosts_validator.py` to throw a `ValueError` if any allowed host contains 'https://' or 'http://' prefix. * Add a check in the `__init__` method and `set_allowed_hosts` method to throw a `ValueError` if any allowed host contains 'https://' or 'http://' prefix. * Add tests in `packages/abstractions/tests/authentication/test_api_key_authentication_provider.py` to verify that a `ValueError` is thrown when 'https://' or 'http://' prefix is present in allowed host value. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/kiota-python/issues/201?shareId=XXXX-XXXX-XXXX-XXXX).
packages/abstractions/tests/authentication/test_api_key_authentication_provider.py
Show resolved
Hide resolved
baywet
approved these changes
Jan 28, 2025
|
release-please
bot
removed
the
release-please:force-run
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
Add error handling for 'https://' and 'http://' prefixes in allowed host values.
AllowedHostsValidatorclass inpackages/abstractions/kiota_abstractions/authentication/allowed_hosts_validator.pyto throw aValueErrorif any allowed host contains 'https://' or 'http://' prefix.__init__method andset_allowed_hostsmethod to throw aValueErrorif any allowed host contains 'https://' or 'http://' prefix.packages/abstractions/tests/authentication/test_api_key_authentication_provider.pyto verify that aValueErroris thrown when 'https://' or 'http://' prefix is present in allowed host value.For more details, open the Copilot Workspace session.