fix: adds missing mushing of all of scenarios#4723
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
@andrueastman I'm running out of time on this one but I thinks it irons out the last allOf scenarios. If you can review and test, I'd appreciate it. Otherwise I'll pick it up when I get back. I queued a generation build for sanity. |
Pull Request is not mergeable
|
Generation is identical for Microsoft Graph scenarios! microsoftgraph/msgraph-sdk-dotnet#2517 |
Co-authored-by: silaskenneth <silaskenneth1@gmail.com>
79048dc to
a6feb0e
Compare
|
|
Validated with https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=150942&view=results . No diff with latest generation on beta/v1 |
|
Since commit 448af8f (which is the first of this pull request) I see a lot of warnings about discriminator not being inherited when generating my client. For example:
The generated code is identical, only the warnings are new. This problem can be reproduced by debugging the |
|
Thanks for this @0xced. Any chance you can create a new issue with the input openApi document to help investigate? |
|
There's already at least one in the tests where the problem can be reproduced. I edited my previous message after posting it when I figured out that running the |
|
Following this up via #4761 |


fixes #4714
fixes #4191