Skip to content

Change FileStream to allow shared read access#7601

Merged
baywet merged 2 commits intomicrosoft:mainfrom
j4-c4:patch-1
Apr 13, 2026
Merged

Change FileStream to allow shared read access#7601
baywet merged 2 commits intomicrosoft:mainfrom
j4-c4:patch-1

Conversation

@j4-c4
Copy link
Copy Markdown
Contributor

@j4-c4 j4-c4 commented Apr 13, 2026

I have a project that calls kiota generate multiple times, sometimes with the same openapi parameter. Every now and then, it'll fail to build because two kiota instances collided - one kiota instance has a handle on the file while the other was trying to read it. I can reproduce this by debugging this project and breaking on the copyToAsync line, then running my project build. With this change, breaking on that line and building (and making the build use my modified kiota) never throws that error.

@j4-c4 j4-c4 requested a review from a team as a code owner April 13, 2026 11:37
baywet
baywet previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Can you also please add an entry to the changelog? (unreleased, fixed)

@j4-c4
Copy link
Copy Markdown
Contributor Author

j4-c4 commented Apr 13, 2026

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge (squash) April 13, 2026 13:23
@baywet baywet merged commit 86b2984 into microsoft:main Apr 13, 2026
299 checks passed
@j4-c4 j4-c4 deleted the patch-1 branch April 13, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants