Skip to content

Revert "GDK props to import base lhc props and fixed base import (#893)" #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlonsoMondal merged 1 commit into from
Aug 8, 2025
Merged

Revert "GDK props to import base lhc props and fixed base import (#893)" #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Build/libHttpClient.GDK.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
<!-- This file is a replacement for Microsoft.Cpp.Default.Props and Microsoft.Cpp.props for Cpp projects targeting GDK -->

<Import Condition="'$(HCPathsImported)' != 'true'" Project="libHttpClient.paths.props" />

<!-- Import the main libHttpClient props to get include paths -->
<Import Condition="'$(LibHttpClientImported)' != 'true'" Project="..\libHttpClient.props" />

<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|Gaming.Desktop.x64">
Expand Down
6 changes: 1 addition & 5 deletions Build/libHttpClient.import.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@
<!-- This props file pulls in a source reference to LibHttpClient. By default, a reference to the dynamic library version will be used.-->
<!-- To use the static library version, define HCStaticLib=true prior to importing this file-->

<!-- Check if LibHttpClient is already imported -->
<PropertyGroup Condition="'$(LibHttpClientImported)' == 'true'">
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
</PropertyGroup>

<Import Condition="'$(LibHttpClientImported)' == 'true'" Project="Error attempting to import LibHttpClient twice. Condition all imports on ('ProjectName'Imported) != true." />
<PropertyGroup>
<LibHttpClientImported>true</LibHttpClientImported>
</PropertyGroup>
Expand Down